Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cb ceiling middle tier plots #1050

Closed
wants to merge 13 commits into from
Closed

Cb ceiling middle tier plots #1050

wants to merge 13 commits into from

Conversation

gopa-noaa
Copy link
Contributor

Merge cb_ceiling_middle_tier_plots branch with development.
Issues resolved:
cb-ceiling - merge middleware code for multiple plot types #1036
cb-ceiling - too high skill (CSI) score for multiple region plots #1044

@gopa-noaa gopa-noaa added Couchbase MATS An issue affecting the MATS project MATScommon An issue affecting the MATScommon project labels Sep 6, 2023
@gopa-noaa gopa-noaa self-assigned this Sep 6, 2023
This was linked to issues Sep 6, 2023
cb-ceiling - merge middleware code for multiple plot types #1036
Open
cb-ceiling - too high skill (CSI) score for multiple region plots #1044
Closed
@gopa-noaa gopa-noaa removed a link to an issue Sep 6, 2023
cb-ceiling - merge middleware code for multiple plot types #1036
Open
This was linked to issues Sep 6, 2023
cb-ceiling middleware implementation for all station plots #1033
Closed
cb_ceiling - TimeSeries station plot - enhance middleware to do CTC sum-up #997
Closed
cb_ceiling app, middleware implementation for DailyModelCycle plots #972
Closed
cb_ceiling app, middleware implementation for Map plots #970
Closed
mollybsmith-noaa
mollybsmith-noaa requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only change that I think we need is that some files still have import {memoryUsage} from node:process, which doesn't work in our containers for whatever reason. Can you remove this and make sure it's not referenced anywhere?

@gopa-noaa
Copy link
Contributor Author

@mollybsmith-noaa removed memoryUsage imports and pushed

mollybsmith-noaa
mollybsmith-noaa approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The build checks failed, which sometimes just happens because github drops the ball, but can you run cb-ceiling and at least one mysql app locally from your feature branch to make sure everything is working before you merge?

@mollybsmith-noaa
Copy link
Collaborator

The build errors in this PR are because a non-existent METexpress tag was checked in. I will fix it.

@gopa-noaa
Copy link
Contributor Author

MySQL app works fine, merged to development.

@mollybsmith-noaa mollybsmith-noaa deleted the cb_ceiling_middle_tier_plots branch September 11, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollybsmith-noaa mollybsmith-noaa mollybsmith-noaa approved these changes

Assignees

@gopa-noaa gopa-noaa

Labels
Couchbase MATS An issue affecting the MATS project MATScommon An issue affecting the MATScommon project
Projects
None yet
Milestone
No milestone
2 participants
@gopa-noaa @mollybsmith-noaa